[r] Correct parenthesis in covr() call activate quiet=FALSE #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl and
mojaveazure
|
This pull request has been linked to Shortcut Story #42849: [r] Correct misplaced parenthesis in coverage call in r-ci.sh. |
mojaveazure
approved these changes
Mar 9, 2024
eddelbuettel
added a commit
that referenced
this pull request
Mar 11, 2024
eddelbuettel
added a commit
that referenced
this pull request
Mar 11, 2024
johnkerl
pushed a commit
that referenced
this pull request
Mar 13, 2024
…2262) Co-authored-by: Dirk Eddelbuettel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
The
covr()function of the eponymous package has an argumentquietdefaulting to TRUE; our attempt to set it to FALSE was thwarted by the fact that we accidentally included in the other, preceding argument.Changes:
Move one character a few places in both parts of the if/else call.
Notes for Reviewer:
SC 42849