Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Only run build tests when build files are modified #2229

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

jdblischak
Copy link
Collaborator

Issue and/or context:

Changes:

  • Only runs this CI workflow that tests the build steps if the PR/commit modifies a file that involves finding libtiledb and/or libtiledbsoma at build/run time

Notes for Reviewer:

  • These tests are quick, but we noticed that the recently added macOS builds are extremely flaky, often requiring a restart to succeed. It's unclear to me why the macOS builds are so less reliable than the Docker ones

  • For the Python package, I included both setup.py (finds libtiledbsoma at build time) and src/tiledbsoma/__init__.py (finds libtiledbsoma at runtime)

@jdblischak jdblischak requested a review from johnkerl March 7, 2024 14:38
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jdblischak
Copy link
Collaborator Author

And a general comment, we may want to be more aggressive with the path-based filters for our other GitHub Actions workflows as well. An awful lot of CI is running on this PR that only modifies another CI file

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #2229 (146f1f6) into main (92593fd) will decrease coverage by 7.81%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
- Coverage   78.56%   70.76%   -7.81%     
==========================================
  Files         137      103      -34     
  Lines       10684     6871    -3813     
  Branches      215      214       -1     
==========================================
- Hits         8394     4862    -3532     
+ Misses       2192     1923     -269     
+ Partials       98       86      -12     
Flag Coverage Δ
libtiledbsoma 63.98% <ø> (-3.74%) ⬇️
python ?
r 74.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 48.69% <ø> (-0.16%) ⬇️

@jdblischak jdblischak merged commit 7ecc161 into single-cell-data:main Mar 7, 2024
23 checks passed
@jdblischak jdblischak deleted the build-test-ci-paths branch March 7, 2024 16:10
@johnkerl
Copy link
Member

johnkerl commented Mar 7, 2024

Backporting manually since #2231 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants