Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.7] Revert #1937 #2211

Closed
wants to merge 2 commits into from
Closed

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 5, 2024

Same as #2209 but on the release-1.7 branch.

See #2210 and #2219 for tracking.

@johnkerl johnkerl marked this pull request as ready for review March 5, 2024 20:31
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #2211 (b908715) into release-1.7 (86b1933) will decrease coverage by 6.44%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7    #2211      +/-   ##
===============================================
- Coverage        78.56%   72.13%   -6.44%     
===============================================
  Files              137      103      -34     
  Lines            10683     6875    -3808     
  Branches           215      215              
===============================================
- Hits              8393     4959    -3434     
+ Misses            2192     1818     -374     
  Partials            98       98              
Flag Coverage Δ
libtiledbsoma 67.72% <ø> (ø)
python ?
r 74.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 48.85% <ø> (ø)

@johnkerl
Copy link
Member Author

johnkerl commented Mar 6, 2024

Closing: #2220 proves that #1937 did not entirely break dylib-copying for MacOS. All we need is an upcoming PR from @jdblischak.

@johnkerl johnkerl closed this Mar 6, 2024
@johnkerl johnkerl deleted the kerl/revert-1937-1.7 branch March 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants