Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.7] Backport #2158 and #2166 to release-1.7 #2170

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

johnkerl
Copy link
Member

Backports #2158 and #2166 to the release-1.7 branch. As with #2165, I had hoped for a clean backport, but I found on #2158 that that sadly did not occur. Instead, I am re-iterating the approach of #2165, which is a bulk-sync of main to release-1.7 except for these release-specific files:

.github/workflows/r-ci.yml
.github/workflows/r-python-interop-testing.yml
apis/r/DESCRIPTION
apis/r/NEWS.md
apis/r/tools/get_tarball.R
libtiledbsoma/cmake/Modules/FindTileDB_EP.cmake

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #2170 (e15ac1d) into release-1.7 (0641874) will decrease coverage by 6.30%.
The diff coverage is 71.28%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7    #2170      +/-   ##
===============================================
- Coverage        78.38%   72.08%   -6.30%     
===============================================
  Files              135      102      -33     
  Lines            10699     6885    -3814     
  Branches           211      215       +4     
===============================================
- Hits              8386     4963    -3423     
+ Misses            2211     1823     -388     
+ Partials           102       99       -3     
Flag Coverage Δ
libtiledbsoma 67.63% <71.28%> (+0.86%) ⬆️
python ?
r 74.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 48.67% <51.51%> (+0.62%) ⬆️

@johnkerl johnkerl merged commit 3f229df into release-1.7 Feb 23, 2024
21 checks passed
@johnkerl johnkerl deleted the kerl/backport-2158-2166 branch February 23, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants