[python] Refactor pybind11 inheritance to reduce repetition #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenv
force-pushed
the
viviannguyen/refactor-pybind11-inheritance
branch
from
faa7509 to
ce950db
Compare
johnkerl
changed the title
nguyenv
force-pushed
the
viviannguyen/refactor-pybind11-inheritance
branch
from
ce950db to
32decdd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2126 +/- ##
===========================================
+ Coverage 78.47% 91.38% +12.91%
===========================================
Files 136 35 -101
Lines 10679 3784 -6895
Branches 211 0 -211
===========================================
- Hits 8380 3458 -4922
+ Misses 2197 326 -1871
+ Partials 102 0 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
pushed a commit
that referenced
this pull request
Feb 22, 2024
…2162) Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2125
Changes:
DRY: refactor binding code to have proper inheritance from
SOMADataframe,SOMAArray, andSOMAObject.These changes were picked out of #1817. I am opening smaller PRs to make it easier to review this time.
Notes for Reviewer:
These changes are meant to be on top of #2124. Please review that PR first.