[python] Reorganize Reindexer bindings into separate file
#2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
approved these changes
Feb 6, 2024
johnkerl
pushed a commit
that referenced
this pull request
Feb 6, 2024
…2111) Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
In #1793, for readability purposes, the Python bindings were reorganized so that class bindings resided in their own files. In #1728, the
Reindexerbindings were placed intopytiledbsoma.cc, which at the time was the singular file in which all bindings were placed, with plans for a follow-up PR to separate them out.Changes:
The
Reindexerbinding class is now inreindexer.cc.