[python] Add common.h to MANIFEST.in
#2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
reviewed
Jan 22, 2024
|
The latest release of scipy 1.12.0, released Jan 20, seems to be the culprit for CI failures. This PR fixes an unrelated issue having to do with wheel distros. |
nguyenv
force-pushed
the
viviannguyen/wheel-error-missing-common.h
branch
from
26cfba4 to
c1dbb68
Compare
I've opened an issue for this #2036 and will address it in a separate PR. |
thetorpedodog
approved these changes
Jan 22, 2024
johnkerl
pushed a commit
that referenced
this pull request
Jan 22, 2024
Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2032
Changes:
Add
common.htoMANIFEST.inas C++ (source and) header files are not added bysetuptoolsto the distribution by default.Notes for Reviewer:
Proof of working: https://github.com/single-cell-data/TileDB-SOMA/actions/runs/7603111075