Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Error if extending enum past index type limit #1986

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Dec 14, 2023

Issue and/or context:

#1975

Changes:

Raise ValueError if the number of enumerations exceeds the limit of the index value type.

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'd love to get @bkmartinjr 's eyes on it as well

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me.

Base automatically changed from viviannguyen/remap-cate-mult-writes to main December 14, 2023 22:07
@nguyenv nguyenv force-pushed the viviannguyen/handle-past-limit-type branch from 4de4e2c to fea9048 Compare December 14, 2023 22:25
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #1986 (a93df73) into main (d712bf2) will increase coverage by 35.78%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1986       +/-   ##
===========================================
+ Coverage   53.97%   89.75%   +35.78%     
===========================================
  Files         112       34       -78     
  Lines        8780     3603     -5177     
  Branches      161        0      -161     
===========================================
- Hits         4739     3234     -1505     
+ Misses       3966      369     -3597     
+ Partials       75        0       -75     
Flag Coverage Δ
libtiledbsoma ?
python 89.75% <100.00%> (?)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.75% <100.00%> (∅)
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv merged commit 37329c9 into main Dec 14, 2023
11 checks passed
@nguyenv nguyenv deleted the viviannguyen/handle-past-limit-type branch December 14, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants