Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Update DESCRIPTION and NEWS.md for 1.5.2 #1972

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

johnkerl
Copy link
Member

1.5.2 will deliver a Python-only bugfix on the release-1.5 branch. R is not affected, other than our commitment to keep Python and R API versions synchronized.

Please also see https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases

@johnkerl johnkerl requested a review from aaronwolen December 11, 2023 22:20
Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

apis/r/NEWS.md Show resolved Hide resolved
Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@johnkerl
Copy link
Member Author

johnkerl commented Dec 11, 2023

See code comments and also #1818 for the last time this happened, which involved release-1.4 and release-1.5 and core 2.16 and core 2.17.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (361675a) 89.76% compared to head (73a9b09) 63.12%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.5    #1972       +/-   ##
================================================
- Coverage        89.76%   63.12%   -26.65%     
================================================
  Files               34      106       +72     
  Lines             3597    10044     +6447     
================================================
+ Hits              3229     6340     +3111     
- Misses             368     3704     +3336     
Flag Coverage Δ
python 89.76% <ø> (ø)
r 48.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnkerl johnkerl force-pushed the kerl/tiledbsoma-r-1.5.2 branch from d2f7aed to 2b61d04 Compare December 11, 2023 23:21
@johnkerl johnkerl force-pushed the kerl/tiledbsoma-r-1.5.2 branch from 20e95b2 to eb756ae Compare December 12, 2023 17:34
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnkerl johnkerl force-pushed the kerl/tiledbsoma-r-1.5.2 branch 3 times, most recently from ff34cf5 to 743ca3b Compare December 12, 2023 22:25
@johnkerl johnkerl force-pushed the kerl/tiledbsoma-r-1.5.2 branch from 743ca3b to 9fb5830 Compare December 12, 2023 22:25
@johnkerl johnkerl force-pushed the kerl/tiledbsoma-r-1.5.2 branch from 5311b91 to fef2f09 Compare December 12, 2023 23:13
@johnkerl
Copy link
Member Author

[sc-38306]

Copy link

This pull request has been linked to Shortcut Story #38306: Fix from_anndata() to respect var_id_name.

run: |
cd apis/r
Rscript -e 'remove.packages("tiledb")'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need that. It cleanly installs over it.

Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline. Feel free to ignore.

@johnkerl johnkerl merged commit e444529 into release-1.5 Dec 13, 2023
14 checks passed
@johnkerl johnkerl deleted the kerl/tiledbsoma-r-1.5.2 branch December 13, 2023 00:20
johnkerl added a commit that referenced this pull request Jan 8, 2024
johnkerl added a commit that referenced this pull request Jan 8, 2024
* Allow specification of X names on ingest [release-1.6]

* Apply #1972 to `release-1.6`

* code-review feedback

* revert previous commit

* code-review feedback

* Revert commit number 6, back to 2 and 4 (which are the same)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants