-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r] Update DESCRIPTION
and NEWS.md
for 1.5.2
#1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See code comments and also #1818 for the last time this happened, which involved |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #1972 +/- ##
================================================
- Coverage 89.76% 63.12% -26.65%
================================================
Files 34 106 +72
Lines 3597 10044 +6447
================================================
+ Hits 3229 6340 +3111
- Misses 368 3704 +3336
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d2f7aed
to
2b61d04
Compare
20e95b2
to
eb756ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ff34cf5
to
743ca3b
Compare
743ca3b
to
9fb5830
Compare
5311b91
to
fef2f09
Compare
[sc-38306] |
This pull request has been linked to Shortcut Story #38306: Fix from_anndata() to respect var_id_name. |
.github/workflows/r-ci.yml
Outdated
run: | | ||
cd apis/r | ||
Rscript -e 'remove.packages("tiledb")' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need that. It cleanly installs over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline. Feel free to ignore.
* Allow specification of X names on ingest [release-1.6] * Apply #1972 to `release-1.6` * code-review feedback * revert previous commit * code-review feedback * Revert commit number 6, back to 2 and 4 (which are the same)
1.5.2 will deliver a Python-only bugfix on the
release-1.5
branch. R is not affected, other than our commitment to keep Python and R API versions synchronized.Please also see https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases