Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Extend codecov to cover tiledbsoma library #1970

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

beroy
Copy link
Collaborator

@beroy beroy commented Dec 9, 2023

Issue and/or context:

Changes:

Notes for Reviewer:

@beroy beroy changed the title [C++] Extended codecov for tiledbsoma library [WIP] [C++] Extending codecov for tiledbsoma library [WIP] Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #1970 (fd666f6) into main (1b6688b) will increase coverage by 1.55%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   62.83%   64.39%   +1.55%     
==========================================
  Files         106      146      +40     
  Lines       10044    12385    +2341     
  Branches        0      161     +161     
==========================================
+ Hits         6311     7975    +1664     
- Misses       3733     4335     +602     
- Partials        0       75      +75     
Flag Coverage Δ
libtiledbsoma 69.86% <ø> (?)
python 89.76% <ø> (+0.65%) ⬆️
r 48.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.76% <ø> (+0.65%) ⬆️
libtiledbsoma 53.52% <ø> (∅)

@beroy beroy force-pushed the libtiledbsoma_codecov branch 6 times, most recently from 38982ff to f4fe59f Compare December 11, 2023 23:50
@beroy beroy changed the title [C++] Extending codecov for tiledbsoma library [WIP] [C++] Extending codecov for tiledbsoma library Dec 12, 2023
@beroy beroy changed the title [C++] Extending codecov for tiledbsoma library [C++] Extending codecov to cover tiledbsoma library Dec 12, 2023
@beroy beroy force-pushed the libtiledbsoma_codecov branch 2 times, most recently from ecb2068 to 4732dc8 Compare December 12, 2023 00:16
.github/workflows/libtiledb-ci.yml Show resolved Hide resolved
.github/workflows/libtiledb-ci.yml Outdated Show resolved Hide resolved
@beroy beroy force-pushed the libtiledbsoma_codecov branch 3 times, most recently from f8e9500 to ddaa1b3 Compare December 12, 2023 15:17
@beroy beroy force-pushed the libtiledbsoma_codecov branch from ddaa1b3 to fd666f6 Compare December 12, 2023 17:48
Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@beroy beroy merged commit 198b78e into main Dec 13, 2023
15 checks passed
@beroy beroy deleted the libtiledbsoma_codecov branch December 13, 2023 01:07
@jdblischak
Copy link
Collaborator

I don't know why, but after this PR was merged, the nightly tiledbsoma-feedstock builds started failing. Details in TileDB-Inc/tiledbsoma-feedstock#71

@johnkerl johnkerl changed the title [C++] Extending codecov to cover tiledbsoma library [c++] Extending codecov to cover tiledbsoma library Jan 22, 2024
@johnkerl johnkerl changed the title [c++] Extending codecov to cover tiledbsoma library [c++] Extend codecov to cover tiledbsoma library Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants