[python] Normalize unit-test exception coverage #1909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we run our unit tests on more and more environments, including on-image from
docker run
, we more often run into an old unit-test error. Namely,apis/python/tests/test_dataframe_index_columns.py::test_types_read_errors
may either throwRuntimeError
ortiledb.cc.TileDBError
. Yet we only catch the former. This means, for example, when running unit tests fromdocker run
we need to mentally 'subtract out' these spurious fails. (This has already bitten developers, who have become used to it.) What we should be doing is catching both. (Also note: grepping forRuntimeError
inapis/python/tests
show we already do this in other unit-test files -- we need to do it in one more.)