Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix an import statement #1865

Closed
wants to merge 1 commit into from
Closed

[python] Fix an import statement #1865

wants to merge 1 commit into from

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 5, 2023

Running python -m pytest tests from apis/python on my laptop I am seeing

FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.1-shape0-coords0] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.1-shape1-coords1] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.1-shape2-coords2] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape3-coords3] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape4-coords4] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape5-coords5] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape6-coords6] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape7-coords7] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape8-coords8] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape9-coords9] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape10-coords10] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape12-coords12] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape13-coords13] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape14-coords14] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape15-coords15] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape16-coords16] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.05-shape17-coords17] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.005-shape18-coords18] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.005-shape19-coords19] - ModuleNotFoundError: No module named 'sparse'
FAILED tests/test_sparse_nd_array.py::test_blockwise_table_iter_reindex[0.005-shape20-coords20] - ModuleNotFoundError: No module named 'sparse'

which makes sense given the "before" on this PR. In fact, I don't understand how this didn't fail in CI as well.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
apis/python/src/tiledbsoma/_read_iters.py 94.68% <100.00%> (ø)

... and 72 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl marked this pull request as draft November 5, 2023 21:41
@johnkerl johnkerl closed this Nov 5, 2023
@johnkerl johnkerl deleted the kerl/import-fix branch November 7, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants