Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Outgest uns #1770

Merged
merged 4 commits into from
Oct 18, 2023
Merged

[python] Outgest uns #1770

merged 4 commits into from
Oct 18, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 9, 2023

Issue and/or context: #1764

Changes:

Notes for Reviewer: This PR is ready for review.

@johnkerl johnkerl changed the base branch from main to kerl/uns-2d-string-array-ingest October 9, 2023 14:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
apis/python/src/tiledbsoma/io/ingest.py 87.74% <83.87%> (+0.19%) ⬆️

... and 75 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl force-pushed the kerl/uns-2d-string-array-ingest branch from f775b86 to fee4da3 Compare October 9, 2023 20:04
Base automatically changed from kerl/uns-2d-string-array-ingest to main October 9, 2023 21:25
@johnkerl johnkerl force-pushed the kerl/uns-outgest branch 3 times, most recently from 304d634 to e39fbad Compare October 9, 2023 22:07
@johnkerl johnkerl marked this pull request as ready for review October 16, 2023 22:11
@johnkerl johnkerl changed the title [python] Outgest uns [WIP] [python] Outgest uns Oct 16, 2023
@johnkerl
Copy link
Member Author

@aaronwolen @nguyenv @thetorpedodog ping 🙏

@nguyenv
Copy link
Member

nguyenv commented Oct 18, 2023

I did see this PR a few days ago but noticed some TODO comments so didn't review yet. Is that meant to be done in this PR or in a subsequent one?

edit: Sorry, just noticed the note. Will review.

@johnkerl
Copy link
Member Author

Thanks @nguyenv ! :)

@johnkerl johnkerl merged commit 71a799a into main Oct 18, 2023
9 checks passed
@johnkerl johnkerl deleted the kerl/uns-outgest branch October 18, 2023 15:07
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
* [python] `uns` outgest [WIP]

* logging

* unit-test cases

* code-review feedback
johnkerl added a commit that referenced this pull request Oct 18, 2023
* [python] `uns` outgest [WIP]

* logging

* unit-test cases

* code-review feedback

Co-authored-by: John Kerl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants