Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Allow adata.X to be None #1767

Merged
merged 4 commits into from
Oct 9, 2023
Merged

[python] Allow adata.X to be None #1767

merged 4 commits into from
Oct 9, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 9, 2023 •
edited
Loading

Issue and/or context: Issue #1672. Extends PR #1762.

Changes:

Notes for Reviewer:

This was referenced Oct 9, 2023
Merged
Closed
@johnkerl johnkerl changed the base branch from main to kerl/anndata-0-9-workaround October 9, 2023 13:52
@johnkerl johnkerl force-pushed the kerl/x-none branch 5 times, most recently from fcb7b92 to 1237888 Compare October 9, 2023 14:02
@johnkerl
Copy link
Member Author

johnkerl commented Oct 9, 2023

This is stacked atop the blocking PR #1766 until that PR is merged, at which point this PR will be on main.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
apis/python/src/tiledbsoma/io/ingest.py 87.41% <100.00%> (-0.02%) ⬇️

... and 76 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Base automatically changed from kerl/anndata-0-9-workaround to main October 9, 2023 19:57
eddelbuettel
eddelbuettel approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too.

thetorpedodog
thetorpedodog approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion(s) which you can take or leave

apis/python/src/tiledbsoma/io/ingest.py Show resolved Hide resolved
@johnkerl johnkerl merged commit 066fe36 into main Oct 9, 2023
9 checks passed
@johnkerl johnkerl deleted the kerl/x-none branch October 9, 2023 21:07
github-actions bot pushed a commit that referenced this pull request Oct 9, 2023
@johnkerl @github-actions
[python] Allow adata.X to be None (#1767)
64650e8 
* [python] Ingest `adata.X==None`

* [python] Ingest `adata.X==None`

* neaten

* code-review feedback
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
Merged
johnkerl added a commit that referenced this pull request Oct 9, 2023
@github-actions @johnkerl
[python] Allow adata.X to be None (#1767) (#1772)
376a4f6 
* [python] Ingest `adata.X==None`

* [python] Ingest `adata.X==None`

* neaten

* code-review feedback

Co-authored-by: John Kerl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetorpedodog thetorpedodog thetorpedodog approved these changes

@nguyenv nguyenv nguyenv approved these changes

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnkerl @codecov-commenter @eddelbuettel @nguyenv @thetorpedodog