Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicates for is-SOMA and is-SOMA-collection #176

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jun 20, 2022

Context: #163

Example:

import tiledbsc

for path in [
  '/Users/johnkerl/mini-corpus',
  '/Users/johnkerl/mini-corpus/atlas',
  '/Users/johnkerl/mini-corpus/atlas/acute-covid19-cohort',
  '/Users/johnkerl/mini-corpus/atlas/acute-covid19-cohort/obs',
]:
    ans1 = tiledbsc.util.is_soma_collection(path)
    ans2 = tiledbsc.util.is_soma(path)
    print(ans1, ans2, path)
False False /Users/johnkerl/mini-corpus
True False /Users/johnkerl/mini-corpus/atlas
False True /Users/johnkerl/mini-corpus/atlas/acute-covid19-cohort
False False /Users/johnkerl/mini-corpus/atlas/acute-covid19-cohort/obs

@bkmartinjr
Copy link
Member

Slightly related to this, while we are adding metadata do you anticipate also needing an encoding version number? Put another way, is there benefit to encoding the file format version so that the underlying TileDB object organization can evolve separately from the API?

@Shelnutt2
Copy link
Contributor

Slightly related to this, while we are adding metadata do you anticipate also needing an encoding version number? Put another way, is there benefit to encoding the file format version so that the underlying TileDB object organization can evolve separately from the API?

Adding version numbers is usually the best thing to do. By the time you want to use the version number its usually too late and things are in the wild. Starting with one and not using it doesn't really cost much of anything.

@bkmartinjr
Copy link
Member

fully agree! To my mind, this one is a "Tiledb instantiated (file format) for SOMA" version, and should be shared by all implementations on top of TileDB (eg, all languages/environments)

@johnkerl
Copy link
Member Author

Thanks @bkmartinjr and @Shelnutt2 ! I'll merge this PR to avoid rebases etc but will put up another for versioning 🙏

@johnkerl johnkerl merged commit c9bb1f7 into main Jun 21, 2022
@johnkerl johnkerl deleted the kerl/existence branch June 21, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants