[python] Enumerations-API refinement #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenv
commented
Oct 4, 2023
nguyenv
force-pushed
the
viviannguyen/enum-api-refinement
branch
from
4edc807 to
99652a8
Compare
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 75 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
nguyenv
force-pushed
the
viviannguyen/enum-api-refinement
branch
3 times, most recently
from
a8a7d88 to
82494b3
Compare
|
|
nguyenv
force-pushed
the
viviannguyen/enum-api-refinement
branch
from
e1fb7aa to
79d94c7
Compare
|
There is actually two more corrections I need to do. I already solved one. If there are no new enumeration values, then do not evolve the schema (before, we were extending with an empty list). But there's one more issue having to do with Boolean enums. |
johnkerl
reviewed
Oct 30, 2023
nguyenv
force-pushed
the
viviannguyen/enum-api-refinement
branch
from
408c349 to
08fc2bf
Compare
* This was a problem with a local build where TileDB-Py was built with a different version of core than libtiledbsoma, causing the reader and writer to enter different libtiledb codepaths
nguyenv
force-pushed
the
viviannguyen/enum-api-refinement
branch
from
08fc2bf to
47aa7f6
Compare
* Force exporting v3 assays with SeuratObject v5 installed SeuratObject v5 creates v5 assays by default (didn't always). This PR sets options in `SOMAExperimentAxisQuery$to_seurat()` and `SOMAExperimentAxisQuery$to_seurat_assay()` to force SeuratObject to create v3 assays instead of v5 ones Addresses chanzuckerberg/cellxgene-census#816 * Add tests to ensure v3 assays are exported even if v5 is installed * Update tests to not name `slot` in `GetAssayData()` * Don't name `slot` in `SetAssayData()` * Don't name `slot` in `GetAssayData()` * Temporarily stop using `expect_no_condition()` due to bug in SeuratObject
* [c++/python] Depends on core 2.17.3 and TileDB-Py 0.23.2 * Point at dev tiledb-r from #1835
nguyenv
force-pushed
the
viviannguyen/enum-api-refinement
branch
from
1cce1f5 to
1a3a500
Compare
johnkerl
approved these changes
Oct 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Add unit test where subsequent write introduces new category value * Only Extend If New Values Found, Add New Values in Order
johnkerl
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Add unit test where subsequent write introduces new category value * Only Extend If New Values Found, Add New Values in Order Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#1746
Changes:
DataFrame.createextend_enumeration, test creating empty enumeration TileDB-Inc/TileDB-Py#1847; passing locally when built against this branch