[c++] Rework SOMAArray reader iterator sequence
#1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34827: Background research for SOMA array-reader iterator does submit before next and should not, increasing latency. |
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. see 43 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
nguyenv
force-pushed
the
viviannguyen/sc-34827/background-research-for-soma-array-reader
branch
from
d87b406 to
206beeb
Compare
johnkerl
changed the title
SOMAArray Reader Iterator SequenceSOMAArray reader iterator sequence
nguyenv
force-pushed
the
viviannguyen/sc-34827/background-research-for-soma-array-reader
branch
from
3e51a0b to
6b4c522
Compare
eddelbuettel
suggested changes
Oct 2, 2023
johnkerl
approved these changes
Oct 3, 2023
johnkerl
deleted the
viviannguyen/sc-34827/background-research-for-soma-array-reader
branch
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* [c++] Rework `SOMAArray` Reader Iterator Sequence * Set Up Buffers BEFORE Returning * Rename Functions, Modify R Code * Submit Read When Query is Empty * Correct `first_read_next_` setting * [WIP] Remove Coverage "just to see" * [WIP] View Test Output If Failed * Update Packages in R CI * Also Update in R-Python Interop * Replace apt install with Rscript -e 'update.packages(ask=FALSE)' * Restore Coverage
johnkerl
pushed a commit
that referenced
this pull request
Oct 3, 2023
* [c++] Rework `SOMAArray` Reader Iterator Sequence * Set Up Buffers BEFORE Returning * Rename Functions, Modify R Code * Submit Read When Query is Empty * Correct `first_read_next_` setting * [WIP] Remove Coverage "just to see" * [WIP] View Test Output If Failed * Update Packages in R CI * Also Update in R-Python Interop * Replace apt install with Rscript -e 'update.packages(ask=FALSE)' * Restore Coverage Co-authored-by: Vivian Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#1744
Changes:
read_next()is calledSOMAArray::submit()