-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on core 2.17.1, TileDB-Py 0.23.1, TileDB-R 0.21.1 #1731
Conversation
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. see 35 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
IIUC R CI
b/c for source we have 0.21.1
|
One way is to add this again: - name: Install r-universe build of tiledb-r (macOS)
if: ${{ matrix.os == 'macOS-latest' }}
run: cd apis/r && Rscript -e "install.packages('tiledb', repos = c('https://eddelbuettel.r-universe.dev', 'https://cloud.r-project.org'))"
- name: Install r-universe build of tiledb-r (linux)
if: ${{ matrix.os != 'macOS-latest' }}
run: cd apis/r && Rscript -e "options(bspm.version.check=TRUE); install.packages('tiledb', repos = c('https://eddelbuettel.r-universe.dev/bin/linux/jammy/4.3/', 'https://cloud.r-project.org'))" PPM did not run yesterday (unusual), and has not run today (can happen) so new official r2u binary of tiledb(-r) 0.21.1 (or any other updated CRAN packages). For tiledb-r the r-universe alternate makes a good fix. |
@eddelbuettel is there a good reason we shouldn't simply leave this in? |
@johnkerl We could indeed. I was careful not to push it too much, not being a company resource etc pp. We would then always test with 'master branch of tiledb-r' which would not be a bad test. All this could be part of a broader discussion about how we may want to rejig the building and testing of various intertwined components here. (What we really want is a magic wand or a more fault tolerant routine here. "Try r2u if it has the binary, else build from source (slower) or resort to r-universe" is one (not coded-up but plausible) approach. I think right we can through the fix back it because it is not part of the released package but really only part of what happens in GitHub Actions. "And what happens in GitHub Actions stays in GitHub Actions....". Otherwise lame that r2u "prod" is delayed but such is life.) |
Thanks @eddelbuettel -- I think I get it now. (We've discussed such things before, but, non-R-expert that I am, it can take a while to "sink in".
I think this is not a state we want to remain in TBH. We should be testing against tagged-and-released software. This mod is only appropriate when we are testing tagged-and-released software (b/c we know within our heads) and are only working around a binary-artifact propagation delay which is (a) too long, and (b) completely out of our control. I'll put reverting this mod on my to-do list for a subsequent PR, once the binaries have propagated. Thanks again for explaining (again)! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Depend on core 2.17.1, TileDB-Py 0.23.1, TileDB-R 0.21.1 * code-review feedback
* Depend on core 2.17.1, TileDB-Py 0.23.1, TileDB-R 0.21.1 * code-review feedback Co-authored-by: John Kerl <[email protected]>
#866