[r] Replace three local utility functions with use of RcppInt64 #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
johnkerl,
nguyenv,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #34753: [r] Replace two utility functions with use of RcppInt64 package equivalents. |
johnkerl
approved these changes
Sep 27, 2023
eddelbuettel
added a commit
that referenced
this pull request
Sep 27, 2023
… (#1724) Co-authored-by: Dirk Eddelbuettel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
This PR reduces the code surface by replacing three
integer64conversion utility functions with use from the RcppInt64 package. A similar change was made to the tiledb-r package in a recent PR.Changes:
Remove three helper functions, add a header import in two C++ files.
Notes for Reviewer:
SC 34753