[r] Update SOMADataFrame$create() to automatically mark ordered()
#1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an check in `SOMADataFrame$create()` to detect if a column in the schema is ordered. If so, automatically mark the enumerations as such. Note: this only happens if: - there are enumerations for the column - the column in the arrow schema is marked as ordered - there is no attribute `'ordered'` on the enumerations for the column
|
This pull request has been linked to Shortcut Story #34681: |
johnkerl
approved these changes
Sep 26, 2023
eddelbuettel
approved these changes
Sep 26, 2023
Update changelog [ci skip]
mojaveazure
deleted the
paulhoffman/sc-34681/somadataframecreate-does-not-respect-ordered
branch
|
Backport CI is not triggering; I will manually create a backport PR for |
johnkerl
added a commit
that referenced
this pull request
Sep 27, 2023
johnkerl
added a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an check in
SOMADataFrame$create()to detect if a column in the schema is ordered. If so, automatically mark the enumerations as such.Note: this only happens if
'ordered'on the enumerations for the column