[python] Support enumerations in update_obs/update_var
#1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/enumvolve
branch
3 times, most recently
from
2db25ea to
5fdd9a3
Compare
johnkerl
changed the title
update_obs/update_var [WIP]update_obs/update_var [WIP]
johnkerl
force-pushed
the
kerl/enumvolve
branch
from
5fdd9a3 to
07133e9
Compare
johnkerl
force-pushed
the
kerl/enumvolve
branch
from
07133e9 to
f636d09
Compare
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. see 37 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
johnkerl
changed the title
update_obs/update_var [WIP]update_obs/update_var [WIP]
|
This is having a weird CI fail cc @ihnorton I thought we resolved all mac-CI issues a couple weeks ago but I may have missed something ... 👀 🤔 |
johnkerl
changed the title
update_obs/update_var [WIP]update_obs/update_var
aaronwolen
approved these changes
Sep 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
* [python] Support enumerations in `update_obs`/`update_var` [WIP] * expand unit tests * silence a warning * Avoid unnecessary MacOS 3.7 check * experimenting * code-review feedback
johnkerl
added a commit
that referenced
this pull request
Sep 29, 2023
…1736) * [python] Support enumerations in `update_obs`/`update_var` [WIP] * expand unit tests * silence a warning * Avoid unnecessary MacOS 3.7 check * experimenting * code-review feedback Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Validates
update_obs/update_varwhen the newly added column is an enumeration: tracking issue #1710, with grandparent #866.Changes:
Notes for Reviewer: