[c++] Fix for empty-indexed multi-dimensional array #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #34502: CZI: SparseNDArray read returns incorrect result when one dim is empty-indexed. |
johnkerl
changed the title
Codecov ReportPatch has no changes to coverable lines.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
johnkerl
deleted the
viviannguyen/sc-34502/czi-sparsendarray-read-returns-incorrect
branch
|
Analysis here: #1703 (comment) |
johnkerl
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: Vivian Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#1703
Changes:
Modify
subarray_range_empty_to be a mapping of dimension name to whether the query range is empty.is_empty_query()returns true if any of the ranges are empty.