Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Don't use Python to generate C++ test inputs #1668

Merged
merged 13 commits into from
Sep 12, 2023
Merged

Conversation

johnkerl
Copy link
Member

Issue and/or context: Found in #1511 / #866 et al. while attempting pre-tag/pre-merge tests with core 2.17.0-rc0. Here we use tiledbsoma-py to generate test data for libtiledbsoma code. That's currently failing due to tiledbsoma-py in the generator step being built with core 2.16 rather than 2.17. But this highlights a bigger issue: let's not be circular in our test paths. Rather, let's validate C++ code using C++ and shell tools; then move up the testing stack to Python and R.

Changes: Simply can the generated inputs into test/soco.tgz. As an added bonus we get some backward-compatilbility test here.

Notes for Reviewer:

@johnkerl johnkerl requested a review from nguyenv September 11, 2023 14:53
@johnkerl johnkerl changed the title [c++] Don't use to generate test inputs [c++] Don't use Python to generate C++ test inputs Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head cca1a81 differs from pull request most recent head 97e746a. Consider uploading reports for the commit 97e746a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

📢 Thoughts on this report? Let us know!.

@johnkerl johnkerl mentioned this pull request Sep 11, 2023
@johnkerl johnkerl merged commit a1a5b84 into main Sep 12, 2023
@johnkerl johnkerl deleted the kerl/test-soco-tgz branch September 12, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants