-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Don't use Python to generate C++ test inputs #1668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
[c++] Don't use to generate test inputs
[c++] Don't use Python to generate C++ test inputs
Sep 11, 2023
Codecov ReportPatch has no changes to coverable lines.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. 📢 Thoughts on this report? Let us know!. |
Closed
nguyenv
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Found in #1511 / #866 et al. while attempting pre-tag/pre-merge tests with core 2.17.0-rc0. Here we use
tiledbsoma-py
to generate test data forlibtiledbsoma
code. That's currently failing due totiledbsoma-py
in the generator step being built with core 2.16 rather than 2.17. But this highlights a bigger issue: let's not be circular in our test paths. Rather, let's validate C++ code using C++ and shell tools; then move up the testing stack to Python and R.Changes: Simply can the generated inputs into
test/soco.tgz
. As an added bonus we get some backward-compatilbility test here.Notes for Reviewer: