-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniformization examples #161
Conversation
bc86412
to
437ef27
Compare
1bf4ae7
to
ad1e3a0
Compare
c804b7a
to
17e2313
Compare
apis/python/examples/normalizing.md
Outdated
## Normalizing a SOMA collection | ||
|
||
The [cartographer script](../examples/cartographer.py) shows an example of how to take a collection | ||
of H5AD files -- and/or already-ingested SOMAs -- and _normalize_ them into a uniform collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... and aggregate them into a uniform collection." (again, not overusing the world normalize)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkmartinjr thanks! i want to be clear we're not doing any concat
operation though ... if someone has 27 .h5ad
files they'll have a SOCO with 27 SOMAs in it ... how best clearly to indicate that fact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose the word "aggregate" rather than "concat", but am open to others.
To my eye, "aggregate" does not imply a concat operation, but I take your point that we could be more specific.
Perhaps "... shows an example of how to take multiple H5AD files and add them to a single SOMA Collection."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two more tweaks to make the MD and code match. With those changes, LGTM
fd637e7
to
d8d1c91
Compare
Split out from #157
uniform-collection.md shows an optional way to ingest data, with opinionated uniformization. This example is intended as a template for how a given organization can automate their data-uniformization procedure.