Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformization examples #161

Merged
merged 4 commits into from
Jun 22, 2022
Merged

Uniformization examples #161

merged 4 commits into from
Jun 22, 2022

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jun 14, 2022

Split out from #157

uniform-collection.md shows an optional way to ingest data, with opinionated uniformization. This example is intended as a template for how a given organization can automate their data-uniformization procedure.

@johnkerl johnkerl requested a review from bkmartinjr June 14, 2022 16:00
@johnkerl johnkerl force-pushed the kerl/normalization-example branch from bc86412 to 437ef27 Compare June 20, 2022 21:25
@johnkerl johnkerl marked this pull request as ready for review June 20, 2022 21:27
@johnkerl johnkerl force-pushed the kerl/normalization-example branch 3 times, most recently from 1bf4ae7 to ad1e3a0 Compare June 21, 2022 16:50
@johnkerl johnkerl changed the title Draft normalization examples Normalization examples Jun 21, 2022
@johnkerl johnkerl force-pushed the kerl/normalization-example branch 3 times, most recently from c804b7a to 17e2313 Compare June 22, 2022 18:02
## Normalizing a SOMA collection

The [cartographer script](../examples/cartographer.py) shows an example of how to take a collection
of H5AD files -- and/or already-ingested SOMAs -- and _normalize_ them into a uniform collection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... and aggregate them into a uniform collection." (again, not overusing the world normalize)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkmartinjr thanks! i want to be clear we're not doing any concat operation though ... if someone has 27 .h5ad files they'll have a SOCO with 27 SOMAs in it ... how best clearly to indicate that fact?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose the word "aggregate" rather than "concat", but am open to others.

To my eye, "aggregate" does not imply a concat operation, but I take your point that we could be more specific.

Perhaps "... shows an example of how to take multiple H5AD files and add them to a single SOMA Collection."

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more tweaks to make the MD and code match. With those changes, LGTM

@johnkerl johnkerl force-pushed the kerl/normalization-example branch from fd637e7 to d8d1c91 Compare June 22, 2022 20:45
@johnkerl johnkerl changed the title Normalization examples Uniformization examples Jun 22, 2022
@johnkerl johnkerl merged commit c26d58a into main Jun 22, 2022
@johnkerl johnkerl deleted the kerl/normalization-example branch June 23, 2022 13:57
@johnkerl johnkerl mentioned this pull request Jun 24, 2022
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants