Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial group/array metadata access methods #116

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Initial group/array metadata access methods #116

merged 1 commit into from
Jun 2, 2022

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented May 24, 2022

This introduces some metadata accessors but doesn't yet put them to use.

Places to use them include #106, where:

  • For columns, we'll store original category-type names (for anndata categoricals which were downcast to TileDB strings)
  • For arrays, we'll store information like "this was originally CSR" or "this was originally CSC"
  • For uns, we'll store scalars no longer as length-1 arrays but rather as group metadata
  • For SOMA objects, we'll store information like "this was written by tiledbsc-r v0.1.2

See also #115 which is stacked atop this.

Note: this is stacked atop #144, hence the higher line-count -- see https://github.com/single-cell-data/TileDB-SingleCell/pull/116/commits

@johnkerl johnkerl marked this pull request as draft May 24, 2022 16:27
@johnkerl johnkerl changed the title Initial group/array metadata access methods Initial group/array metadata access methods [WIP] May 24, 2022
@johnkerl johnkerl force-pushed the kerl/meta branch 9 times, most recently from ac6d884 to 56ce5cd Compare May 28, 2022 01:25
@johnkerl johnkerl force-pushed the kerl/meta branch 5 times, most recently from c933d56 to ac4a203 Compare June 2, 2022 14:36
@johnkerl johnkerl marked this pull request as ready for review June 2, 2022 14:56
@johnkerl johnkerl changed the title Initial group/array metadata access methods [WIP] Initial group/array metadata access methods Jun 2, 2022
@johnkerl johnkerl requested review from aaronwolen and gspowley June 2, 2022 14:57
@johnkerl johnkerl force-pushed the kerl/meta branch 5 times, most recently from 27bb7e1 to c7cd62f Compare June 2, 2022 16:19
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

apis/python/src/tiledbsc/tiledb_object.py Outdated Show resolved Hide resolved
@johnkerl johnkerl merged commit 84fa41a into main Jun 2, 2022
@johnkerl johnkerl deleted the kerl/meta branch June 2, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants