[python/r] Dense arrays can fail to consolidate with out-of-bounds error [tracking] #3383
Assignees
Labels
Comments
johnkerl
changed the title
|
The core PR TileDB-Inc/TileDB#5390 is approved |
|
This will go out with core 2.27.0. Closing, as TileDB-Inc/TileDB#5390 tracks this. Additionally, that fix will go into the next tiledb-py release, not the upcoming tiledbsoma 1.15.0, as tiledbsoma does not (yet) expose the core conslidation API. (Another good reason not to have a tiledbsoma tracking issue open for this.) |
ihnorton
pushed a commit
to TileDB-Inc/TileDB
that referenced
this issue
Dec 4, 2024
…rent domain (#5390) This PR addresses a bug in the `Domain::expand_to_tiles(NDRange*)` function, which previously did not respect the current domain. The lack of this consideration led to errors when the tile extent was larger than the current domain, causing out-of-bounds issues during consolidation. To resolve this, the PR introduces a new function that appropriately accounts for the current domain. [sc-59793] and single-cell-data/TileDB-SOMA#3383 Huge kudos to @-johnkerl for getting 99.9% of this done. --- TYPE: BUG DESC: This PR fixes a bug in `Domain::expand_to_tiles(NDRange*)`, which failed to respect the current domain, causing errors when tile extents exceeded it. A new function is introduced to properly account for the current domain during consolidation. --------- Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #2407 and in particular core 2.27 support for core's "current domain" (soma "domain") in dense arrays written by
tiledbsoma, a consolidation invoked by TileDB-Py/TileDB-R/Core can fail withThis is a core defect, not a tiledbsoma defect, but this GitHub issue is for tracking.
(Also note that
tiledbsomadoes not expose a consolidation API.)[sc-59793]
The text was updated successfully, but these errors were encountered: