[C++] fixing zero size lookup chunk size for the C++ Re-indexer (#2062)

Co-authored-by: Behnam Robatmili <[email protected]>
single-cell-data · Jan 25, 2024 · e8ddd19 · e8ddd19
1 parent 1082e39
commit e8ddd19
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/apis/python/tests/test_indexer.py b/apis/python/tests/test_indexer.py
@@ -171,8 +171,30 @@ def indexer_test_pass(keys: np.array, lookups: np.array):
         "pass": True,
     },
     {
-        "keys": [1, 2, 3, 4, 5, 2**63 - 1],
-        "lookups": [i for i in range(2**63 - 1000, 2**63 - 1)],
+        "keys": [i for i in range(1, 10000)],
+        "lookups": [
+            525,
+            1293,
+            1805,
+            5802,
+            7636,
+            7754,
+            7791,
+            7957,
+            7959,
+            8067,
+            8340,
+            8736,
+            8806,
+            9329,
+            9377,
+            9653,
+        ],
+        "pass": True,
+    },
+    {
+        "keys": [i for i in range(1, 10000)],
+        "lookups": [i for i in range(1, 10000)],
         "pass": True,
     },
 ]

diff --git a/libtiledbsoma/src/reindexer/reindexer.cc b/libtiledbsoma/src/reindexer/reindexer.cc
@@ -111,6 +111,9 @@ void IntIndexer::lookup(const int64_t* keys, int64_t* results, int size) {
     std::vector<tiledbsoma::ThreadPool::Task> tasks;
 
     size_t thread_chunk_size = size / tiledb_thread_pool_->concurrency_level();
+    if (thread_chunk_size == 0) {
+        thread_chunk_size = 1;
+    }
 
     for (size_t i = 0; i < size_t(size); i += thread_chunk_size) {
         size_t start = i;