Skip to content

Commit

Permalink
next attempt at mypy / query_condition CI fail
Browse files Browse the repository at this point in the history
  • Loading branch information
johnkerl committed Oct 12, 2022
1 parent 62cf7f1 commit be4901b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
2 changes: 0 additions & 2 deletions apis/python/src/tiledbsoma/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
get_SOMA_version,
get_storage_engine,
)
from .query_condition import QueryCondition
from .soma_collection import SOMACollection
from .soma_dataframe import SOMADataFrame
from .soma_dense_nd_array import SOMADenseNdArray
Expand Down Expand Up @@ -71,5 +70,4 @@
"SOMAMeasurement",
"SOMAMetadataMapping",
"SOMASparseNdArray",
"QueryCondition",
]
5 changes: 2 additions & 3 deletions apis/python/src/tiledbsoma/soma_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@
# This package's pybind11 code
import tiledbsoma.libtiledbsoma as clib

# from .query_condition import QueryCondition
from . import query_condition as qcmodule
from . import util, util_arrow
from .logging import log_io
from .query_condition import QueryCondition # type: ignore
from .soma_collection import SOMACollectionBase
from .tiledb_array import TileDBArray
from .types import Ids, NTuple, SOMAResultOrder
Expand Down Expand Up @@ -180,7 +179,7 @@ def read(
with self._tiledb_open("r") as A:
query_condition = None
if value_filter is not None:
query_condition = qcmodule.QueryCondition(value_filter)
query_condition = QueryCondition(value_filter)

# As an arg to this method, `column_names` is optional-None. For the pybind11
# code it's optional-[].
Expand Down
4 changes: 2 additions & 2 deletions apis/python/src/tiledbsoma/soma_indexed_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
# This package's pybind11 code
import tiledbsoma.libtiledbsoma as clib

from . import query_condition as qcmodule
from . import util, util_arrow
from .query_condition import QueryCondition
from .soma_collection import SOMACollectionBase
from .tiledb_array import TileDBArray
from .types import Ids, NTuple, SOMAResultOrder
Expand Down Expand Up @@ -225,7 +225,7 @@ def read(
with self._tiledb_open("r") as A:
query_condition = None
if value_filter is not None:
query_condition = qcmodule.QueryCondition(value_filter)
query_condition = QueryCondition(value_filter) # type: ignore

# As an arg to this method, `column_names` is optional-None. For the pybind11
# code it's optional-[].
Expand Down

0 comments on commit be4901b

Please sign in to comment.