Skip to content

Commit

Permalink
code-review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
johnkerl committed Mar 14, 2024
1 parent 8f28849 commit bd5bfd9
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/r-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,16 @@ jobs:
- name: Install BioConductor package SingleCellExperiment
run: cd apis/r && tools/r-ci.sh install_bioc SingleCellExperiment

# The next two stanzas are necessary given propagation delay for binaries at
# https://r2u.stat.illinois.edu/ which may lack binaries (for short periods of usually a day)
# when sources have been updated. The default installation could switch to installation from
# sources --- but that would require installing all build dependencies. To see what the most
# recent binary is run e.g. docker run --rm -ti rocker/r2u bash -c 'apt update -qq &&
# apt-cache show r-cran-tiledb' Using the r-universe builds (as below) is a suitable fallback
# as they update more frequently than CRAN.
#

# Uncomment these next two stanzas as needed whenever we've just released a new tiledb-r for
# which source is available but CRAN releases (and hence update r2u binaries) are not yet:
#
# IMPORTANT: these two stanzas should remain uncommented _only_ during the propagation time
# between (a) publication of source for a new TileDB-R _upon which_ TileDB-SOMA depends in its
# apis/R/DESCRIPTION file and (b) appearance of binaries.
#
# Please see https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases which
# is crucial for anyone doing releases of TileDB-SOMA.

#- name: Install r-universe build of tiledb-r (macOS)
# if: ${{ matrix.os == 'macOS-latest' }}
Expand Down

0 comments on commit bd5bfd9

Please sign in to comment.