Skip to content

Commit

Permalink
read/write Table
Browse files Browse the repository at this point in the history
  • Loading branch information
johnkerl committed Oct 4, 2022
1 parent 8193c21 commit ae2bde1
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, macos-12, windows-2019]
os: [ubuntu-22.04, macos-11, windows-2019]
python-version: ['3.8']
include:
- runs-on: ubuntu-22.04
cc: gcc-11
cxx: g++-11
- runs-on: macos-12
# Pending https://github.com/actions/runner-images/issues/6350
- runs-on: macos-11
cc: gcc-11
cxx: g++-11

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/cpp-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, macos-12]
os: [ubuntu-22.04, macos-11]
python-version: ['3.8']
include:
- runs-on: ubuntu-22.04
cc: gcc-11
cxx: g++-11
# Pending https://github.com/actions/runner-images/issues/6350
# - runs-on: macos-12
- runs-on: macos-11
cc: gcc-11
cxx: g++-11
Expand Down
8 changes: 4 additions & 4 deletions apis/python/src/tiledbsoma/soma_dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,13 @@ def _get_is_sparse(self) -> bool:

return self._cached_is_sparse

def write(self, values: pa.RecordBatch) -> None:
def write(self, values: pa.Table) -> None:
"""
Write an Arrow.RecordBatch to the persistent object.
Write an Arrow.Table to the persistent object.
:param values: An Arrow.RecordBatch containing all columns, including the index columns. The schema for the values must match the schema for the ``SOMADataFrame``.
:param values: An Arrow.Table containing all columns, including the index columns. The schema for the values must match the schema for the ``SOMADataFrame``.
The ``values`` Arrow RecordBatch must contain a ``soma_rowid`` (uint64) column, indicating which rows are being written.
The ``values`` Arrow Table must contain a ``soma_rowid`` (uint64) column, indicating which rows are being written.
"""
self._shape = None # cache-invalidate

Expand Down

0 comments on commit ae2bde1

Please sign in to comment.