[c++] Correct results_complete (#1816) (#1831)

* After setting `results_complete = false` for incomplete queries, the variable was not updated to `true` once it completed Co-authored-by: nguyenv <[email protected]>
single-cell-data · Oct 25, 2023 · 9625db2 · 9625db2
1 parent 243563b
commit 9625db2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/libtiledbsoma/src/soma/managed_query.cc b/libtiledbsoma/src/soma/managed_query.cc
@@ -176,6 +176,8 @@ std::shared_ptr<ArrayBuffers> ManagedQuery::submit_read() {
     // complete.
     if (status == Query::Status::INCOMPLETE) {
         results_complete_ = false;
+    } else if (status == Query::Status::COMPLETE) {
+        results_complete_ = true;
     }
 
     // Update ColumnBuffer size to match query results

diff --git a/libtiledbsoma/test/test_soma_array.py b/libtiledbsoma/test/test_soma_array.py
@@ -77,14 +77,10 @@ def test_soma_array_var_x_data():
     # The := "walrus" operator is really the appropriate thing here, but alas, is not
     # supported in Python 3.7 which we do wish to preserve compatibility with.
     # while arrow_table := sr.read_next():
-    while True:
+    while not sr.results_complete():
         arrow_table = sr.read_next()
-        if not arrow_table:
-            break
         total_num_rows += arrow_table.num_rows
 
-    # test that all results are not present in the arrow table (incomplete queries)
-    assert not sr.results_complete()
     assert total_num_rows == 4848644