Skip to content

Commit

Permalink
[r] More fixes for unit-test cases with dense + core 2.27 (#3280)
Browse files Browse the repository at this point in the history
* [r] More fixes for unit-test cases with dense + core 2.27

* DESCRIPTION and NEWS.md [skip ci]
  • Loading branch information
johnkerl authored Nov 2, 2024
1 parent 5f154bf commit 747fdcf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion apis/r/DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Description: Interface for working with 'TileDB'-based Stack of Matrices,
like those commonly used for single cell data analysis. It is documented at
<https://github.com/single-cell-data>; a formal specification available is at
<https://github.com/single-cell-data/SOMA/blob/main/abstract_specification.md>.
Version: 1.15.99.14
Version: 1.15.99.15
Authors@R: c(
person(given = "Aaron", family = "Wolen",
role = c("cre", "aut"), email = "[email protected]",
Expand Down
1 change: 1 addition & 0 deletions apis/r/NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* Apply `styler::style_pkg()` [#3239](https://github.com/single-cell-data/TileDB-SOMA/pull/3239)
* Plumb old-style `SOMATileDBContext` into new-style `soma_context()` [#3252](https://github.com/single-cell-data/TileDB-SOMA/pull/3252)
* Fixes for dense arrays and yet-to-be-released core 2.27 [#3270](https://github.com/single-cell-data/TileDB-SOMA/pull/3270)
* More fixes for unit-test cases with dense + core 2.27 [#3280](https://github.com/single-cell-data/TileDB-SOMA/pull/3280)

# tiledbsoma 1.14.5

Expand Down
4 changes: 2 additions & 2 deletions apis/r/tests/testthat/test-shape.R
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ test_that("SOMADenseNDArray shape", {

# Test writes within new bounds
ndarray <- SOMADenseNDArrayOpen(uri, "WRITE")
mat <- create_dense_matrix_with_int_dims(300, 400)
mat <- create_dense_matrix_with_int_dims(500, 600)
if (tiledbsoma:::.dense_arrays_can_have_current_domain()) {
expect_no_error(ndarray$write(mat))
} else {
Expand All @@ -625,7 +625,7 @@ test_that("SOMADenseNDArray shape", {
ndarray <- SOMADenseNDArrayOpen(uri)
coords <- list(bit64::as.integer64(c(101, 202)), bit64::as.integer64(c(3, 4)))
if (tiledbsoma:::.dense_arrays_can_have_current_domain()) {
expect_no_condition(x <- ndarray$read(coords = coords)$tables()$concat())
expect_no_condition(x <- ndarray$read_dense_matrix(coords = coords))
} else {
expect_error(x <- ndarray$read(coords = coords)$tables()$concat())
}
Expand Down

0 comments on commit 747fdcf

Please sign in to comment.