audit misuse of string_view

single-cell-data · Jan 13, 2023 · 5151b6f · 5151b6f
1 parent d905bd9
commit 5151b6f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/libtiledbsoma/include/tiledbsoma/soma_reader.h b/libtiledbsoma/include/tiledbsoma/soma_reader.h
@@ -66,8 +66,8 @@ class SOMAReader {
         std::string_view name = "unnamed",
         std::map<std::string, std::string> platform_config = {},
         std::vector<std::string> column_names = {},
-        std::string_view batch_size = "auto",
-        std::string_view result_order = "auto");
+        std::string batch_size = "auto",
+        std::string result_order = "auto");
 
     /**
      * @brief Open an array at the specified URI and return SOMAReader object.
@@ -85,8 +85,8 @@ class SOMAReader {
         std::string_view uri,
         std::string_view name = "unnamed",
         std::vector<std::string> column_names = {},
-        std::string_view batch_size = "auto",
-        std::string_view result_order = "auto");
+        std::string batch_size = "auto",
+        std::string result_order = "auto");
 
     //===================================================================
     //= public non-static
@@ -103,8 +103,8 @@ class SOMAReader {
         std::string_view name,
         std::shared_ptr<Context> ctx,
         std::vector<std::string> column_names,
-        std::string_view batch_size,
-        std::string_view result_order);
+        std::string batch_size,
+        std::string result_order);
 
     SOMAReader() = delete;
     SOMAReader(const SOMAReader&) = delete;
@@ -121,8 +121,8 @@ class SOMAReader {
      */
     void reset(
         std::vector<std::string> column_names = {},
-        std::string_view batch_size = "auto",
-        std::string_view result_order = "auto");
+        std::string batch_size = "auto",
+        std::string result_order = "auto");
 
     /**
      * @brief Set the dimension slice using one point

diff --git a/libtiledbsoma/src/pyapi/libtiledbsoma.cc b/libtiledbsoma/src/pyapi/libtiledbsoma.cc
@@ -136,8 +136,8 @@ PYBIND11_MODULE(libtiledbsoma, m) {
                         std::optional<std::vector<std::string>> column_names_in,
                         py::object py_query_condition,
                         py::object py_schema,
-                        std::string_view batch_size,
-                        std::string_view result_order,
+                        std::string batch_size,
+                        std::string result_order,
                         std::map<std::string, std::string> platform_config) {
                 // Handle optional args
                 std::vector<std::string> column_names;
@@ -209,8 +209,8 @@ PYBIND11_MODULE(libtiledbsoma, m) {
                std::optional<std::vector<std::string>> column_names_in,
                py::object py_query_condition,
                py::object py_schema,
-               std::string_view batch_size,
-               std::string_view result_order) {
+               std::string batch_size,
+               std::string result_order) {
                 // Handle optional args
                 std::vector<std::string> column_names;
                 if (column_names_in) {

diff --git a/libtiledbsoma/src/soma_reader.cc b/libtiledbsoma/src/soma_reader.cc
@@ -46,8 +46,8 @@ std::unique_ptr<SOMAReader> SOMAReader::open(
     std::string_view name,
     std::map<std::string, std::string> platform_config,
     std::vector<std::string> column_names,
-    std::string_view batch_size,
-    std::string_view result_order) {
+    std::string batch_size,
+    std::string result_order) {
     return std::make_unique<SOMAReader>(
         uri,
         name,
@@ -62,8 +62,8 @@ std::unique_ptr<SOMAReader> SOMAReader::open(
     std::string_view uri,
     std::string_view name,
     std::vector<std::string> column_names,
-    std::string_view batch_size,
-    std::string_view result_order) {
+    std::string batch_size,
+    std::string result_order) {
     return std::make_unique<SOMAReader>(
         uri, name, ctx, column_names, batch_size, result_order);
 }
@@ -77,8 +77,8 @@ SOMAReader::SOMAReader(
     std::string_view name,
     std::shared_ptr<Context> ctx,
     std::vector<std::string> column_names,
-    std::string_view batch_size,
-    std::string_view result_order)
+    std::string batch_size,
+    std::string result_order)
     : ctx_(ctx)
     , uri_(util::rstrip_uri(uri)) {
     // Validate parameters
@@ -97,8 +97,8 @@ SOMAReader::SOMAReader(
 
 void SOMAReader::reset(
     std::vector<std::string> column_names,
-    std::string_view batch_size,
-    std::string_view result_order) {
+    std::string batch_size,
+    std::string result_order) {
     // Reset managed query
     mq_->reset();