[python] Fix inconsistent handling of column_names in ExperimentAxisQuery.to_anndata #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetorpedodog
approved these changes
Jan 19, 2023
| # even if we added our own above. | ||
| if column_names is not None: | ||
| arrow_table = arrow_table.select(column_names) | ||
| # Drop soma_joinid column if we added it soley for use in filling |
There was a problem hiding this comment.
Suggested change
| # Drop soma_joinid column if we added it soley for use in filling | |
| # Drop soma_joinid column if we added it solely for use in filling |
johnkerl
changed the title
johnkerl
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: single-cell-data/TileDB-SOMA#755 and chanzuckerberg/cellxgene-census#56
This PR modifies the
ExperimentAxisQuery.to_anndata()to return columns consistent with other API, i.e., returned obs/var columns will be the union of columns explicitly requested viacolumn_namesparameter, and columns referenced in the AxisQueryvalue_filter.Fixes single-cell-data/TileDB-SOMA#755
See unit test in single-cell-data/TileDB-SOMA#763