Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings for new-shape feature #250

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 4, 2024

Issue and/or context: As tracked on issue single-cell-data/TileDB-SOMA#2407 [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in single-cell-data/TileDB-SOMA#2407

Changes:

Notes for Reviewer:

@johnkerl johnkerl force-pushed the kerl/new-shape-docstrings branch from 494864a to dabc8dd Compare December 4, 2024 19:16
Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ltgm. Minor typing suggestions.

python-spec/src/somacore/data.py Show resolved Hide resolved
python-spec/src/somacore/data.py Show resolved Hide resolved
@johnkerl
Copy link
Member Author

johnkerl commented Dec 4, 2024

@nguyenv alas on my most recent commit I get

python-spec/src/somacore/data.py:176: error: X | Y syntax for unions requires Python 3.10  [syntax]
python-spec/src/somacore/data.py:310: error: X | Y syntax for unions requires Python 3.10  [syntax]
Found 2 errors in 1 file (checked 21 source files)

@johnkerl johnkerl merged commit e49776b into main Dec 4, 2024
6 checks passed
@johnkerl johnkerl deleted the kerl/new-shape-docstrings branch December 4, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants