Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python spec for geometry dataframe #200

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Jun 14, 2024

Changes:

  • Add a new GeometryDataFrame class
  • Adds shapely as a somacore Python dependency.

WIP:

  • How we want to handle the two-dimensional geometry index dimension for both schema specification needs further investigation.

Issues: Closes single-cell-data/TileDB-SOMA#2677

@jp-dark
Copy link
Collaborator Author

jp-dark commented Jun 14, 2024

[sc-43829]

@jp-dark jp-dark requested a review from aaronwolen June 14, 2024 15:59
@jp-dark jp-dark force-pushed the dark/geometry-dataframe branch from b9e99fa to 3e0c0dd Compare June 28, 2024 19:45
Copy link
Member

@pablo-gar pablo-gar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the naming of the introduced object and methods. I defer to others on the API review.

@jp-dark jp-dark force-pushed the dark/geometry-dataframe branch 4 times, most recently from 9add2f5 to f4d198b Compare August 16, 2024 14:49
@jp-dark jp-dark force-pushed the dark/geometry-dataframe branch from f4d198b to b56daca Compare August 19, 2024 20:43
@jp-dark jp-dark force-pushed the dark/geometry-dataframe branch 2 times, most recently from f1ff29b to 6c742b1 Compare August 22, 2024 13:48
@jp-dark jp-dark force-pushed the dark/geometry-dataframe branch from 6c742b1 to a365904 Compare August 22, 2024 15:58
@jp-dark jp-dark marked this pull request as ready for review August 22, 2024 19:18
@jp-dark jp-dark merged commit b7d034d into spatial Aug 22, 2024
7 checks passed
@jp-dark jp-dark deleted the dark/geometry-dataframe branch August 22, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants