Allow impl-specific platform_config values
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specifies that implementations may provide their own types to be passed as `platform_config`, and that other implementations should ignore things they don’t recognize.
bkmartinjr
approved these changes
May 15, 2023
|
@pablo-gar bump, since this a spec change I would like all reviewers' approval. (If I misremembered the conversation and you didn’t have an opinion on this, you can remove yourself from the reviewers list (or approve if you think this is a good idea anyway).) |
pablo-gar
approved these changes
May 17, 2023
13 tasks
johnkerl
changed the title
platform_config values.platform_config values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specifies that implementations may provide their own types to be passed as
platform_config, and that other implementations should ignore things they don’t recognize.Per the discussion at Friday’s meeting about allowing users to pass in rich objects, this is roughly what I was thinking would be the best approach. It’s pretty much what I said there, and tl;dr
I only vaguely remember who was most involved in that discussion, so please R+ anybody who seems relevant.
Tracking: single-cell-data/TileDB-SOMA#1394