[python] Don't use TypeVar when defining coordinate types
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous change which used TypeVar for coordinate types [1] was actually a Bad Idea. While it was better in that it prohibited heterogeneous collections and slices, it was worse in that made the SparseDFCoord type (and derived types) into generic types, which we do not want. The *right* way to avoid repeating all the possible types is to make a union of the possible *containers*, and then specify *that* with all the possible contents that may go into those containers. [1]: #141
johnkerl
changed the title
TypeVar when defining coordinate types
bkmartinjr
approved these changes
Mar 3, 2023
johnkerl
approved these changes
Mar 3, 2023
johnkerl
changed the title
TypeVar when defining coordinate typesTypeVar when defining coordinate types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous change which used TypeVar for coordinate types 1 was actually a Bad Idea. While it was better in that it prohibited heterogeneous collections and slices, it was worse in that made the SparseDFCoord type (and derived types) into generic types, which we do not want.
The right way to avoid repeating all the possible types is to make a union of the possible containers, and then specify that with all the possible contents that may go into those containers.