Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Make Slice protocol not runtime_checkable #128

Merged
merged 1 commit into from
Feb 15, 2023

Commits on Feb 15, 2023

  1. Make Slice protocol not runtime_checkable.

    Since `range` has the members `start`/`stop`/`step`, that meant that
    `isinstance(range(x), Slice)` would return True, when a `range` is *not*
    a `Slice`.  Instead, we only provide the `is_slice_of` function
    (originally from `tiledbsoma`) to perform the appropriate type check.
    
    This also unrestricts `Slice`s from being `Comparable`, since the
    built-in `slice` type does not have this restriction.
    thetorpedodog committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f2c066a View commit details
    Browse the repository at this point in the history