-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDL-19802: Add new streams talk_phone_numbers and ticket_metrics_event #111
Merged
kethan1122
merged 29 commits into
master
from
TDL-19802-Add-New-Streams-talk_phone_numbers-And-ticket_metrics_event
Jun 14, 2023
Merged
TDL-19802: Add new streams talk_phone_numbers and ticket_metrics_event #111
kethan1122
merged 29 commits into
master
from
TDL-19802-Add-New-Streams-talk_phone_numbers-And-ticket_metrics_event
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs-And-ticket_metrics_event
zachharris1
approved these changes
Jun 5, 2023
zachharris1
pushed a commit
that referenced
this pull request
Jun 14, 2023
#111) * TDL-19802: Add new streams talk_phone_numbers and ticket_metrics_event * resolevd pylint error * add unittest * add unitests for both newly added streams * add streams in base.py * remove exception * exclude ola field from test_all_field test case * remove token field from talk_pjone_numbers all field test case * updated start_date in base.py * ignore talk_phone_numbers for bookmark test * add new fields * change start date * change start date * add backoff for connectionReseterror and chunkencoding error * add backoff for connectionReseterror and chunkencoding error * add backoff for connectionReseterror and Protocol error * connection reset error * remove backoffs * revert http changes and all fields test * revert http changes * revert http changes * use builtin libraries * merge with master * adjust integration tests * adjust pagination test * make time as date-time format * chnagelog and version bump --------- Co-authored-by: Jay Tilala <[email protected]> Co-authored-by: kethan1122 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps