Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for subdomain #52

Merged
merged 13 commits into from
Oct 29, 2024
Merged

Add support for subdomain #52

merged 13 commits into from
Oct 29, 2024

Conversation

somethingmorerelevant
Copy link
Member

@somethingmorerelevant somethingmorerelevant commented Oct 21, 2024 •
edited
Loading

Description of change

  • Adds support for zendesk.com domain
  • add's fallback mechanism to switch between both the domains since the tokens generated on the old endpoint are not compatible with the new endpoint

Manual QA steps

  • Tested Old and new platform tokens

Risks

  • Low

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@somethingmorerelevant somethingmorerelevant merged commit 66a8384 into master Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdeshmukh15 rdeshmukh15 rdeshmukh15 approved these changes

@prijendev prijendev prijendev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somethingmorerelevant @prijendev @rdeshmukh15