Tdl 18828 add integration tests #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushiT0122
requested changes
Nov 7, 2022
There was a problem hiding this comment.
Tests are not following standard pattern we usually follow for tap-tester integration tests. Please refer QA TESTING PROCESS FOR SAAS TAPS for more details.
Also you can refer tap-tester test suites in other existing taps. Let me know if you need any help with it.
somethingmorerelevant
added a commit
that referenced
this pull request
Nov 16, 2022
* added pre-commit and updated gitignore * updated file structure * fixed sync.py * fixed discovery * fixed streams * removed pendulum dependancy * added pagination support to bans stream * Fixed unittests as per new code refactoring changes. * added config param for bans stream page size * added warning for 400 exception * added replication method to catalog * fixed automatic fields issue * fixed discovery changes * fixed pylint issue * minor enhancements * fixed review comments * fixed discovery changes * removed duplicate function * Tdl 18828 add integration tests (#47) * add automation fields * added test for all_fields and automatic fields * added pagination test * fix bookmark test * fixed naming conventions * fixed assert for automatic fields Co-authored-by: shantanu73 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added Following integration tests
Manual QA steps
Risks
Rollback steps