Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start date test #30

Merged
merged 3 commits into from
May 12, 2021
Merged

Add start date test #30

merged 3 commits into from
May 12, 2021

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented May 6, 2021

Description of change

This PR:

  • adds test_start_date.py to check that incremental streams respect the start date
  • fixes test expectations: Agents is not an incremental stream

Manual QA steps

  • Ran these tests locally

Risks

  • Low

Rollback steps

  • revert this branch

@cosimon cosimon merged commit 0cadd3e into master May 12, 2021
@cosimon cosimon deleted the start_date_test branch May 12, 2021 19:22
@leslievandemark leslievandemark mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimon cosimon cosimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luandy64 @cosimon @leslievandemark