Several improvements #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stream Chats returns the last chat from the previous sync. With this change only new chats will be returned by adding 1 millisecond to the bookmark value
For the stream agents the replication mode was not set because it is either a full-table sync (always returning the whole table) nor a incremental sync (always returning incremental data).
description is taken from API doc. page: https://developer.zendesk.com/rest_api/docs/chat/chats
ghost
mentioned this pull request
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
I found it difficult to work with this tap since it is based on an older version of singer, so I did several improvements to it:
Stream Chats returns the last chat from the previous sync. With this change only new chats will be returned by adding 1 millisecond to the bookmark value
For the stream agents the replication mode was not set because it is either a full-table sync (always returning the whole table) nor a incremental sync (always returning incremental data).
Descriptions are taken from the API doc. page
Feel free to cherry-pick when you guys don't want to use all of my changes.
Manual QA steps
Risks
Rollback steps