Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agents.json #16

Merged
merged 5 commits into from
Feb 1, 2019
Merged

Update agents.json #16

merged 5 commits into from
Feb 1, 2019

Conversation

EternalLearner42
Copy link
Contributor

Here is the update asked for in #15 @luandy64

For some reason I cannot figure out, the colon in the "scope " line is highlighted in red. From what I've been researching, it seems that it's related to some kind of syntax error... though I completely fail to see why, considering it is typed exactly like the rest of them. Do you know how to fix that?

@luandy64
Copy link
Contributor

luandy64 commented Feb 1, 2019

This new scope object you added should look exactly like the email object on line 88, for example. To get rid of the red highlight: I believe we change the ] that's highlighted to a }, indent things properly, and get rid of the comma after type: [].

Hope that all makes sense.

@EternalLearner42
Copy link
Contributor Author

Check my latest PR, I already changed the ] to a }

The indentation is a bit of a mess, let me change the whole file's indentation to try to make it clearer, I can't even find this comma you mention.

@EternalLearner42
Copy link
Contributor Author

Sorry, while you were writing I was fixing the indentation and ended up finding that I placed one } unnecessarily. It's fixed now, and I've also put the extra comma. There are no syntax errors now 👍

@luandy64
Copy link
Contributor

luandy64 commented Feb 1, 2019

No worries, I reloaded the page and saw you were making changes.

This looks good to me. I'm going to merge this.

@luandy64 luandy64 merged commit 4161028 into singer-io:master Feb 1, 2019
@EternalLearner42
Copy link
Contributor Author

Nice! Glad to be of assistance. Feel free to ask for my help again in future issues if needed

@luandy64
Copy link
Contributor

luandy64 commented Feb 1, 2019

Thanks for working on this @EternalLearner42!

If you want more practice dealing with JSON, I'm sure there are other issues in Singer-io that are schema related. I encourage you to dig through the repos if you want to contribute more 👍

Also, join the Singer Slack Channel! We can talk about issues there easier too.

@EternalLearner42
Copy link
Contributor Author

I'll try, am looking all around for issues good enough for a beginner like me to solve.

I don't have a Slack account, but I suppose I can create one, I'll do it as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants