Introduce new stream - campaign_insights_by_province #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushiT0122
reviewed
Jul 24, 2023
Comment on lines
153
to
164
| "conversion_rate_v2": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "real_time_conversion_rate_v2": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Any reason these fields have type string instead of number?
There was a problem hiding this comment.
yes, the documentation mentions the data type as a string. link - https://ads.tiktok.com/marketing_api/docs?id=1751454162042882
There was a problem hiding this comment.
Updated the field type to the number after reading the documentation, as it will only display rates which will be the numeric value.
sgandhi1311
force-pushed
the
TDL-23578-new-stream-campaign-province
branch
from
2711e16
to
d016cb4
Compare
rdeshmukh15
reviewed
Jul 25, 2023
done |
rdeshmukh15
approved these changes
Jul 25, 2023
sgandhi1311
force-pushed
the
TDL-23578-new-stream-campaign-province
branch
from
aaa69aa
to
7cefd82
Compare
sgandhi1311
force-pushed
the
TDL-23578-new-stream-campaign-province
branch
from
7cefd82
to
10712f6
Compare
RushiT0122
approved these changes
Jul 26, 2023
luandy64
approved these changes
Jul 26, 2023
sgandhi1311
added a commit
that referenced
this pull request
Aug 3, 2023
* modify API endpoint * add fields in the campaigns schema * schema changes for adgroup * fix unit test * Schema changes for ads stream * advertisers schema change * update Advertisers key properties * update field types for insight/s streams * set the advertiser_id if it is not present in record * update placement field to placement_type * setup and changelog updates * add few more fields in the ads and adgroups stream * pass the advertiser_id in the param as json formatted string * fix failing unit test cases * update changelog * add new fields for the insight related streams * address review comments * add new field - rf_campaign_type in the schemas * remove aeo_type field * update primary key for advertisers stream in the base.py * modify all fields test * update docs links in readme * update field type for conversion rates * retry for code - 40100 * fix the integration tests * remove few fields from test all field test * Introduce new stream - campaign_insights_by_province (#25) * Add new stream - campaign_insights_by_province * update base.py with the new stream - campaign_insights_by_province * remove user_action field from the campaign insights stream * update the README.md file to include the latest stream details. * format the campaign insights json file * update field type for conversion rates * remove campaigns by province stream from start date and pagination
sgandhi1311
added a commit
that referenced
this pull request
Aug 17, 2023
* modify API endpoint * add fields in the campaigns schema * schema changes for adgroup * fix unit test * Schema changes for ads stream * advertisers schema change * update Advertisers key properties * update field types for insight/s streams * set the advertiser_id if it is not present in record * update placement field to placement_type * setup and changelog updates * add few more fields in the ads and adgroups stream * pass the advertiser_id in the param as json formatted string * fix failing unit test cases * update changelog * add new fields for the insight related streams * address review comments * add new field - rf_campaign_type in the schemas * remove aeo_type field * update primary key for advertisers stream in the base.py * modify all fields test * update docs links in readme * update field type for conversion rates * retry for code - 40100 * fix the integration tests * remove few fields from test all field test * Introduce new stream - campaign_insights_by_province (#25) * Add new stream - campaign_insights_by_province * update base.py with the new stream - campaign_insights_by_province * remove user_action field from the campaign insights stream * update the README.md file to include the latest stream details. * format the campaign insights json file * update field type for conversion rates * remove campaigns by province stream from start date and pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
On customer demand, they would like to track campaign data based on province.
Customer feedback: "We need to be able to run reports based on province, as a lot of our campaign ad spend is earmarked for certain regions or states. Breakdown by campaign, province and just province would be extremely useful to us."
This PR contains the necessary changes required to introduce any new stream.
Manual QA steps
Risks
Rollback steps