Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the following streams: credit notes, credit note line items and customer balance transactions #51

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Ra0k
Copy link

@Ra0k Ra0k commented Feb 24, 2020

Description of change

Implement missing features for credit notes, credit note line items and customer balance transactions. In addition, it also adds some missing properties to invoices' schema.

Technical details

Credit notes, credit note line items and customer balance transactions cannot be filtered by the created field so they are interpreted as the substreams of invoices and customers. Moreover, the stream credit note line items is the substream of credit notes. So if credit note line items is selected, credit notes and invoices are must be selected. (!!)

As stream invoices might have multiple selected substream, the logic had to be changed at some points.

Risks

  • unknown

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @Ra0k, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @Ra0k!

Thank you for signing the Singer Contribution License Agreement.

@tcboles
Copy link

tcboles commented Jun 14, 2021

What is
the status on this pull request? Do we expect this to be merged in the near future?

@joshuaballoch
Copy link

+1 on wondering about the status of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants