Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Refunds and fix Dispute schema for evidence column #168

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support Refunds and fix Dispute schema for evidence column #168

wants to merge 4 commits into from

Conversation

ilkkapeltola
Copy link

Description of change

This PR does two things:

  • Adds working support for Refunds, which for some reason has so far not been included in the tap
  • Fixes the schema for disputes.evidence. In the current form, the elt fails with the snowflake target (pipelinewise variant) due to the wrong schema

Manual QA steps

  • run the ELT

Risks

  • Others using the tap might have done other custom fixes for the dispute column. It doesn't fail on all rows, just some.

Rollback steps

  • revert this branch

syahdeini
syahdeini approved these changes Mar 9, 2023
View reviewed changes
Copy link

@syahdeini syahdeini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syahdeini syahdeini syahdeini approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilkkapeltola @syahdeini