Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties in schemas #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CoopTang
Copy link

Description of change

Adds missing properties in the schemas for items and payments. These fields were added due to target-bigquery not being able to validate the schema without these additional properties

Manual QA steps

Risks

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @CoopTang, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @CoopTang!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants