Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump singer-python dependency to 5.9.1 #67

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Oct 28, 2020

Description of change

This change updates the singer-python dependency to 5.9.1. This is specifically to enable the filtering of nested fields based on the catalog metadata which is important for tap-shopify as it is common to not want to pull personally identifiable information (PII) such as addresses and emails which are nested inside other logical objects.

I did not think that this change warranted any additional unit tests as there is no actual code change to this project.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Manual QA

  • Pulled data using tap and verified records.

Risks

Rollback steps

  • revert this branch

Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changes 5.4.1->5.9.1, and they seem safe. 👍

@dmosorast dmosorast merged commit bb1be60 into singer-io:master Oct 29, 2020
@dmosorast dmosorast mentioned this pull request Oct 29, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants